-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: gsoc subscribe #4727
base: master
Are you sure you want to change the base?
feat: gsoc subscribe #4727
Conversation
53fdd79
to
2b8652a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for this functionality too work,
-
pullsync needs to process each instance of the soc on the same address.
- if a soc has the same postage sstamp as an earlier one, the node it is pushsynced to might not even save it and therefore will not offer it via pullsync
- with different postage stamp but same soc address the soc should be saved and offered via pullsync and the downstrream party should request and save it
-pushsync should never skip pushing the same soc addresss with different payload
these assumptions need to be doublechecked to be sure the functionality makes sense.
it shooould also be properly going through a SWIP
67bd8d7
to
8d8157f
Compare
8d8157f
to
6e28bb2
Compare
this has failing CI checks @nugaon and my global concern is not responded to. |
6166bf1
to
450d973
Compare
Introducing
/gsoc/subscribe/{address}
endpoint which opens a websocket channel for reading incoming payloads of the Single Owner Chunk under the defined address.Closes #4333
Checklist
Description
Open API Spec Version Changes (if applicable)
Motivation and Context (Optional)
Related Issue (Optional)
Screenshots (if appropriate):